Skip to content

Extensions: fix install button type and place of alert in menu#5508

Merged
poulch merged 2 commits intomainfrom
prod-162-fix-button-and-warning
Mar 25, 2025
Merged

Extensions: fix install button type and place of alert in menu#5508
poulch merged 2 commits intomainfrom
prod-162-fix-button-and-warning

Conversation

@poulch
Copy link
Contributor

@poulch poulch commented Mar 25, 2025

Scope of the change

@poulch poulch requested a review from a team March 25, 2025 12:07
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: ae9a9df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@poulch poulch added skip changeset Use if your changes doesn't need entry in changelog run pw-e2e Run e2e (basic suite from PR automation) labels Mar 25, 2025
@codecov
Copy link

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (2797a6a) to head (ae9a9df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Sidebar/menu/ItemGroup.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #5508    +/-   ##
========================================
  Coverage   63.13%   63.14%            
========================================
  Files        1290     1290            
  Lines       22330    22329     -1     
  Branches     4595     4436   -159     
========================================
  Hits        14099    14099            
+ Misses       8195     8194     -1     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

merge-reports: Run #5089

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
235 234 1 0 0 0 0 4m54s

❌ Some tests failed!

Name Failure Message
❌ TC: SALEOR_211 Create a staff member #e2e #staff-members No failure message

Github Test Reporter by CTRF 💚

@poulch poulch merged commit 198743f into main Mar 25, 2025
18 of 25 checks passed
@poulch poulch deleted the prod-162-fix-button-and-warning branch March 25, 2025 12:24
poulch added a commit that referenced this pull request Mar 27, 2025
@poulch
Extensions: fix install button type and place of alert in menu (#5508)
ab12ea8 
* Fix install button

* Fix list group adornment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cloud11PL Cloud11PL Cloud11PL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@poulch @Cloud11PL